[Buildroot] [PATCH v3 13/16] support/testing/infra: add log_file_path() function
Yann E. MORIN
yann.morin.1998 at free.fr
Sun Aug 29 10:42:31 UTC 2021
Hervé, All,
On 2021-08-17 10:39 +0200, Herve Codina spake thusly:
> From: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
>
> Some tests will need to grep through the build log to verify that some
> features are working are expected. In order to allow them to open the
> build log, we provide a new function called log_file_path(), which
> returns the path to the log file if available.
>
> We also use this function in open_log_file().
>
> Note that open_log_file() cannot be used directly to grep through the
> log file at the end of a build: because it opens in "a+" mode, it
> greps starting from the end of the file.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Signed-off-by: Herve Codina <herve.codina at bootlin.com>
This was not really part of the PPD/TLPB stuff, and did not seem to
depend on it in any way, so: applied to next, thanks.
Regards,
Yann E. MORIN.
> ---
> New patch in this v2 series
>
> This patch is retrieved from Thomas's work.
> The first version was discussed
> https://patchwork.ozlabs.org/project/buildroot/patch/20200430095249.782597-10-thomas.petazzoni@bootlin.com/
>
> This new version was not already submitted by Thomas or I missed it.
> Compared to the first version, this patch use a more python-like
> syntax as proposed by Yann in the previous review.
>
> Changes v2 to v3:
> None
>
> support/testing/infra/__init__.py | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/support/testing/infra/__init__.py b/support/testing/infra/__init__.py
> index b10a7601a3..1f003f24c6 100644
> --- a/support/testing/infra/__init__.py
> +++ b/support/testing/infra/__init__.py
> @@ -10,17 +10,18 @@ ARTIFACTS_URL = "http://autobuild.buildroot.net/artefacts/"
> BASE_DIR = os.path.realpath(os.path.join(os.path.dirname(__file__), "../../.."))
>
>
> +def log_file_path(builddir, stage, logtofile=True):
> + """Return path to log file"""
> + return "{}-{}.log".format(builddir, stage) if logtofile else None
> +
> +
> def open_log_file(builddir, stage, logtofile=True):
> """
> Open a file for logging and return its handler.
> If logtofile is True, returns sys.stdout. Otherwise opens a file
> with a suitable name in the build directory.
> """
> - if logtofile:
> - fhandle = open("{}-{}.log".format(builddir, stage), 'a+')
> - else:
> - fhandle = sys.stdout
> - return fhandle
> + return open(log_file_path(builddir, stage, logtofile), 'a+') if logtofile else sys.stdout
>
>
> def basepath(relpath=""):
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list