[Buildroot] [PATCH v2] package/boost: bump version to 1.77.0

Arnout Vandecappelle arnout at mind.be
Thu Aug 26 21:36:17 UTC 2021



On 19/08/2021 15:12, Michael Nosthoff via buildroot wrote:
> * drop 0001-fenv.patch, issue [0] was marked fixed since boost 1.64 (commit [1])
> * drop upstreamed patch 0002
> * filesystem now depends on boost-atomic
> * math broke the build without always lockfree atomic ints, disable for now. reported at [2].
> 
> [0] https://svn.boost.org/trac/boost/ticket/11756
> [1] https://github.com/boostorg/test/commit/cb2a1c2488dc77b9baf1b05781208a9639dfcd69
> [2] https://github.com/boostorg/math/issues/673
> 
> Signed-off-by: Michael Nosthoff <buildroot at heine.tech>


 Applied to master, thanks. With a few more changes though:

    [Arnout: improve propagation of reverse dependencies:
     - also update comment of cc-tool;
     - add boost-filesystem to reason of gnuradio, libcpprestsdk, uhd;
     - move dependency to arch-deps of mongodb]

[snip]
> diff --git a/package/botan/Config.in b/package/botan/Config.in
> index 341fa7c622..635fe1836d 100644
> --- a/package/botan/Config.in
> +++ b/package/botan/Config.in
> @@ -18,8 +18,8 @@ config BR2_PACKAGE_BOTAN
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
>  	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::future
> -	select BR2_PACKAGE_BOOST_FILESYSTEM if BR2_PACKAGE_BOOST
> -	select BR2_PACKAGE_BOOST_SYSTEM if BR2_PACKAGE_BOOST
> +	select BR2_PACKAGE_BOOST_FILESYSTEM if BR2_PACKAGE_BOOST && BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
> +	select BR2_PACKAGE_BOOST_SYSTEM if BR2_PACKAGE_BOOST && BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS

 I suspect there might be a problem here. botan will build with boost as soon as
boost is enabled, even if lockfree atomic ints are not supported. So it's very
well possible that the build will fail on an architecture without them if you
select botan and boost (and not filesystem).

 It may be sufficient to add BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
to the condition in botan.mk - but perhaps botan will automatically enable boost
if it is detected (even if no --with-boost is given). If so, the configure
script will have to be patched to add a --without-boost option so we can disable it.

 Can you take a look? Or you could wait for autobuild failures for botan, but
since you're not a developer for botan you won't get mails for it.

 I've applied without attempting a fix, but I'm pretty sure something will have
to be done.

 Regards,
 Arnout



More information about the buildroot mailing list