[Buildroot] [PATCH 1/1] package/smcroute: bump version to v2.5.0

Joachim Wiberg troglobit at gmail.com
Sat Aug 21 17:30:46 UTC 2021


Hi Thomas!

On Fri, Aug 20, 2021 at 23:32, Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:
> On Fri, 20 Aug 2021 07:44:19 +0200 Joachim Wiberg <troglobit at gmail.com> wrote:
>> -SMCROUTE_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
>> +SMCROUTE_CONF_OPTS = --enable-mrdisc CFLAGS=-std=gnu99
> Thanks for the update. However, passing CFLAGS=-std=gnu99 is not
> correct, as it means other Buildroot CFLAGS are no longer passed.

Ouch, that's obviously not what I intended.  Sorry about that,
and thank you for taking the time to review!

> Instead, it should be:
> SMCROUTE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS -std=gnu99"
> could you see if that works for you, and send an updated version?

Thanks, it was a dirty hack.  I'm going to do a new release upstream
instead, but I'll keep this for next time I run into something simiar.

Also, do you think it would be OK to add an init start script and add
the systemd unit file shipped with SMCRoute?  I belive most users would
appreciate an easy way to start the daemon.  They don't need any .conf
file set up, and we can have everything passive by default.


Best regards
 /Joachim


More information about the buildroot mailing list