[Buildroot] [git commit branch/next] package/freescale-imx/imx-gpu-viv: use make loops instead of shell loops
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Fri Aug 20 21:37:42 UTC 2021
commit: https://git.buildroot.net/buildroot/commit/?id=a75ef4ade159a00c329d376a86390e2a69051d47
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/next
We generally prefer using make loops instead of shell loops. They
bring automatic error handling, as they abort the loop when there is
an error, without the need for "|| exit 1".
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
Reviewed-by: Gary Bisson <gary.bisson at boundarydevices.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
---
package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
index df39d3ddc2..fec19523a3 100644
--- a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
+++ b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
@@ -52,9 +52,9 @@ define IMX_GPU_VIV_FIXUP_PKGCONFIG
endef
else ifeq ($(IMX_GPU_VIV_LIB_TARGET),x11)
define IMX_GPU_VIV_FIXUP_PKGCONFIG
- for lib in egl gbm glesv1_cm glesv2 vg; do \
- ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc || exit 1; \
- done
+ $(foreach lib,egl gbm glesv1_cm glesv2 vg, \
+ ln -sf $(lib)_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$(lib).pc
+ )
endef
endif
@@ -63,9 +63,9 @@ endif
# Make sure these commands are idempotent.
define IMX_GPU_VIV_BUILD_CMDS
cp -dpfr $(@D)/gpu-core/usr/lib/$(IMX_GPU_VIV_LIB_TARGET)/* $(@D)/gpu-core/usr/lib/
- for backend in fb x11 wayland; do \
- $(RM) -r $(@D)/gpu-core/usr/lib/$$backend ; \
- done
+ $(foreach backend,fb x11 wayland, \
+ $(RM) -r $(@D)/gpu-core/usr/lib/$(backend)
+ )
$(IMX_GPU_VIV_FIXUP_PKGCONFIG)
endef
More information about the buildroot
mailing list