[Buildroot] [PATCH 1/1] package/python-pymupdf: depend on python3

Asaf Kahlon asafka7 at gmail.com
Sat Aug 14 06:04:39 UTC 2021


Hello,

On Fri, Aug 13, 2021 at 4:04 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> On Fri, 13 Aug 2021 10:36:34 +0300
> Asaf Kahlon <asafka7 at gmail.com> wrote:
>
> > According to the package documentation, python 3.6 or newer
> > is needed.
> >
> > Fixes:
> >  - http://autobuild.buildroot.net/results/f857986b8c9b6d4a843f3694cae8527760540ed0/
> >
> > Signed-off-by: Asaf Kahlon <asafka7 at gmail.com>
> > ---
> >  package/python-pymupdf/Config.in | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/package/python-pymupdf/Config.in b/package/python-pymupdf/Config.in
> > index 54714eb3bf..64a81895ea 100644
> > --- a/package/python-pymupdf/Config.in
> > +++ b/package/python-pymupdf/Config.in
> > @@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_PYMUPDF
> >       depends on BR2_TOOLCHAIN_HAS_SYNC_4 # mupdf -> harfbuzz
> >       depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # mupdf -> harfbuzz
> >       depends on BR2_PACKAGE_XORG7
> > +     depends on BR2_PACKAGE_PYTHON3
>
> This dependency should have been propagated to the two Config.in
> comments in that file, so that they don't appear if Python3 is not
> used. I fixed that up and applied to master. Thanks!

Hmm that's interesting...
I agree it's needed but from a quick look I think we have packages
which don't do that (for example - txtorcon. If the toolchain doesn't
support C++, we will see the "comment" part under the python2 external
modules menu although python3 is needed).
Do I miss something or is it a real mistake?

>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Thanks,
Asaf.


More information about the buildroot mailing list