[Buildroot] [PATCH 1/1] package/prelink-cross: fix handling of TLS offsets for s390 arch

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Aug 8 20:39:21 UTC 2021


On Sun,  8 Aug 2021 11:48:44 +0200
Alexander Egorenkov <egorenar at linux.ibm.com> wrote:

> /tmp/instance-1/output-1/host/sbin/prelink-rtld: error while loading
> shared libraries: /lib64/libc.so.6: cannot handle TLS data
> ERROR: can't resolve libraries to shared libraries: glib-2.0, gobject-2.0
> ninja: build stopped: subcommand failed.
> make: *** [package/pkg-generic.mk:270:
> /tmp/instance-1/output-1/build/gobject-introspection-1.68.0/.stamp_built]
> Error 1
> make: Leaving directory '/tmp/instance-1/buildroot'

Thanks a lot for having looked at this problem and submitted a patch. I
have applied, after adjusting a bit the commit log, see below.

> 
> Fixes:
> - http://autobuild.buildroot.org/?reason=gobject-introspection-1.68.0&arch=s390x

This is not a correct way to reference an autobuilder failure. Indeed,
this point to a list of failures, which today are what you are fixing,
but tomorrow? Maybe there will be another s390 failure in
gobject-introspection, which is different. This would cause anybody
look at your commit log and following the link to be very confused. So
we always point to one (or several) specific build failures.

> Signed-off-by: Alexander Egorenkov <egorenar at linux.ibm.com>
> ---
>  ...c-Fix-TLS-offsets-computation-for-s3.patch | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 package/prelink-cross/0001-src-rtld-dl-tls.c-Fix-TLS-offsets-computation-for-s3.patch

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list