[Buildroot] [PATCH v2] package/libmodsecurity: fix build with libmaxminddb

Peter Korsgaard peter at korsgaard.com
Sun Aug 8 07:41:17 UTC 2021


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

 > From: Fabrice Fontaine <fontaine.fabrice at gmail.com>
 > Build with libmaxminddb is broken since bump to version 3.0.5 in commit
 > 464d0be380c84ac7c3f1684e49153c3868280d7e because of
 > https://github.com/SpiderLabs/ModSecurity/commit/785958f9b5089b918c7d054cbcc2fe4a3c7b3788

 > So revert this commit until upstream answer to comment to
 > https://github.com/SpiderLabs/ModSecurity/issues/2131

 > Reverting this commit requires autoreconfiguring, which itself causes
 > lots of warnings as configure.ac queries git to know the version of
 > various parts of libmodsecurity. However, it turns out that those
 > versions are only used to be displayed in the output of the configure
 > script, which is quite useless. The only one that is referenced
 > elsewhere is LIBINJECTION_VERSION, but it's in fact a different thing:
 > it is defined by others/libinjection/src/libinjection_sqli.c.

 > The only variable that was AC_SUBST() and therefore visible elsewhere
 > was MSC_GIT_VERSION, but it is not used anywhere in the code base,
 > except in the configure script itself.

 > Note that one patch is 0001 and the other 0003, because there was
 > already a 0002 patch.

 > Fixes:
 >  - http://autobuild.buildroot.org/results/4c639fd967faa06f8ae362bacd38f3409c47267c

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>

Committed to 2021.02.x and 2021.05.x, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list