[Buildroot] [PATCH 1/1] package/libvirt: disable stack-protector

Yann E. MORIN yann.morin.1998 at free.fr
Sat Aug 7 21:20:11 UTC 2021


Fabrice, All,

On 2021-08-07 19:23 +0200, Fabrice Fontaine spake thusly:
> Set warning_level to 1 instead of the default value of 2 to disable
> stack-protector and avoid the following build failure since the addition
> of the package in commit ccfc90e1010e42e6529afae3a5ea8bf7226dabc1:
> 
> /tmp/instance-5/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: tests/commandhelper.p/commandhelper.c.o: in function `printInput':
> commandhelper.c:(.text+0xad): undefined reference to `__stack_chk_guard'

It is sad that they misuse the warning-level option to drive the use
of SSP.

That change is however relatively recent:
    https://gitlab.com/libvirt/libvirt/-/commit/a9461d456c9017322fd10ecc9539c6788a27d476

and that commit only speaks about honouring warning-level for warnings.
It looks like the SSP settings got wrongly pulled into that conditional
blovk by chance only.

Probably, they would not be opposed to a fix that gets SSP back out of
the wanrning-level condition, maybe with an option of its own...

Could you look into that, please?

In the meantime: applied to master, thanks.

Regards,
Yann E. MORIN.

> Fixes:
>  - http://autobuild.buildroot.org/results/a2657eb18b579752c8217ab356adcb52931f6785
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>  package/libvirt/libvirt.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/libvirt/libvirt.mk b/package/libvirt/libvirt.mk
> index a0fd5af951..198e64d24c 100644
> --- a/package/libvirt/libvirt.mk
> +++ b/package/libvirt/libvirt.mk
> @@ -51,6 +51,7 @@ LIBVIRT_CONF_OPTS = \
>  	-Dsysctl_config=enabled \
>  	-Dtest_coverage=false \
>  	-Dudev=enabled \
> +	-Dwarning_level=1 \
>  	-Dwireshark_dissector=disabled
>  
>  ifeq ($(BR2_PACKAGE_ATTR),y)
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list