[Buildroot] [PATCH 2/2] package/{glibc, localedef}: bump to version 2.33-37-g162df872f0dfc2b124a18e1a8c33be63f70d9a1c

[Arnout Vandecappelle]

On 26/04/2021 23:19, Romain Naour wrote:
> Hello Arnout,
> 
> Le 26/04/2021 à 21:36, Arnout Vandecappelle a écrit :
>>
>>
>> On 26/04/2021 12:10, Romain Naour wrote:
>> [snip]
>>>  rename package/glibc/{2.32-37-g760e1d287825fa91d4d5a0cc921340c740d803e2 => 2.33-37-g162df872f0dfc2b124a18e1a8c33be63f70d9a1c}/glibc.hash (70%)
>>>  rename package/localedef/{2.32-37-g760e1d287825fa91d4d5a0cc921340c740d803e2 => 2.33-37-g162df872f0dfc2b124a18e1a8c33be63f70d9a1c}/0001-HACK-only-build-and-install-localedef.patch (100%)
>>>  rename package/localedef/{2.32-37-g760e1d287825fa91d4d5a0cc921340c740d803e2 => 2.33-37-g162df872f0dfc2b124a18e1a8c33be63f70d9a1c}/0002-relax-dependency-on-GCC-to-4.8-and-binutils-to-2.24.patch (100%)
>>>  rename package/localedef/{2.32-37-g760e1d287825fa91d4d5a0cc921340c740d803e2 => 2.33-37-g162df872f0dfc2b124a18e1a8c33be63f70d9a1c}/localedef.hash (70%)
>>
>>  Now you're messing with these packages, maybe you can take the opportunity to
>> get rid of the versioned subdirectory. That's a leftover from when we had
>> version selection for glibc.
> 
> See Yann's reply.
> 
> I'm not a big fan of not having the glibc version choice. I would prefer having
> the choice between the latest version (bleeding-edge) and the previous one
> (stable). Bumping Glibc introduce some breaking change that need to be fixed in
> several packages.

 Although I'm not a fan of version choice at all, there may indeed be a point in
having a choice here, because of all the breakage that glibc introduces.

 There are a couple of caveats though:

- It actually makes our work harder, because we *still* have to fix the
breakage, and we have a harder time detecting it (because less autobuilders will
be using the new glibc version).
- The "stable" version isn't really stable in the usual sense: upstream glibc
doesn't maintain it - so that means we have to do it ourselves. In practice, I
think that means we should track either Debian or SUSE glibc (Redhat is a bit
*too* stable IMHO).
- Usually the glibc fixes are backward compatible, but if there's ever a fix
that breaks older glibc, then we're in a pickle... That said, we already have
that problem with external toolchains, we just ignore it.

 So the only reason to re-introduce the version choice would be for users that
don't want to fix their proprietary packages but do want to update Buildroot.
But then, "stable" would have to stay the same for longer than a single LTS
cycle (in the LTS we already don't update glibc). So I think it's a lot of
effort for little added value in the end.


> For toolchain-builder project, this means that the stable and bleeding-edge
> toolchain use the same glibc version, unlike for other toolchain elements.

 For musl and uClibc we don't have a version choice either.

 Regards,
 Arnout

> 
>>
>> [snip]
>>
>>> diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
>>> index f84f670fc0..e94df73bfe 100644
>>> --- a/package/glibc/glibc.mk
>>> +++ b/package/glibc/glibc.mk
>>> @@ -16,7 +16,7 @@ ifeq ($(BR2_RISCV_32),y)
>>>  # Until 2.33 is released, just use master
>>>  GLIBC_VERSION = 2.32.9000-69-gbd394d131c10c9ec22c6424197b79410042eed99
>>
>>  Since 2.33 is released now, can we use master for riscv32 please?
> 
> Indeed.
> 
> Best regards,
> Romain
> 
>>
>>  Marked as Changes Requested.
>>
>>
>>  Regards,
>>  Arnout
>>
>>
>>>  else
>>> -GLIBC_VERSION = 2.32-37-g760e1d287825fa91d4d5a0cc921340c740d803e2
>>> +GLIBC_VERSION = 2.33-37-g162df872f0dfc2b124a18e1a8c33be63f70d9a1c
>