[Buildroot] [PATCH 1/1] package/cifs-utils: add missing python dependencies

[Peter Seiderer]

Hello Fabrice,

On Mon, 5 Apr 2021 23:24:43 +0200, Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> Hello Peter,
> 
> Le lun. 5 avr. 2021 à 23:08, Peter Seiderer <ps.report at gmx.net> a écrit :
> >
> > Hello Fabrice, Yann,
> >
> > On Sat, 3 Apr 2021 16:52:21 +0200, "Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:
> >  
> > > Fabrice, All,
> > >
> > > On 2021-04-03 15:23 +0200, Fabrice Fontaine spake thusly:  
> > > > Add missing python dependencies which have been forgotten when bumping
> > > > to version 6.12 in commit b5dede7d1a03ab2b8caa0a8e79b09c8df6c62fe4
> > > >
> > > > Fixes:
> > > >  - http://autobuild.buildroot.org/results/acdbf7c58ec8ae648f8048bc75650dcdcdca6285  
> >
> > This autobuild failure points to an libffi error...., quick search of the last
> > autobuild mails did not show an an cifs-utils error (or I did not find it), which
> > failure is this commit fixing?  
> The build failure was indeed raised on libffi because we tried to
> build libffi without threads.
> This build failure is raised because cifs-utils selected python3 if
> python was not selected even if threads were not available.
> However, as python depends on threads, all python modules (such as
> python-cffi) assume that threads are available resulting in the above
> failure on libffi.

....o.k. makes sense...

> >  
> > > >
> > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> > > > ---
> > > >  package/cifs-utils/Config.in | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/package/cifs-utils/Config.in b/package/cifs-utils/Config.in
> > > > index 0e61243de4..55829e3dc2 100644
> > > > --- a/package/cifs-utils/Config.in
> > > > +++ b/package/cifs-utils/Config.in
> > > > @@ -18,9 +18,16 @@ if BR2_PACKAGE_CIFS_UTILS
> > > >
> > > >  config BR2_PACKAGE_CIFS_UTILS_SMBTOOLS
> > > >     bool "smbtools"
> > > > +   depends on BR2_USE_WCHAR # python
> > > > +   depends on BR2_TOOLCHAIN_HAS_THREADS # python
> > > > +   depends on !BR2_STATIC_LIBS # python  
> > >
> > > We select python3, not python, so the added dependencies are because of
> > > python3, not python.
> > >
> > > Comments fixed accordingly, and patch applied to master, thanks.
> > >
> > > Regards,
> > > Yann E. MORIN.
> > >  
> > > >     select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON # runtime  
> >
> > If this commit is fixing an error (and there is a build time dependency on
> > python) than, this comment 'runtime' is no longer valid...  
> The comment is still valid, python is a runtime dependency. You could
> drop this select (and the python dependencies) and cifs-utils will
> build perfectly fine.
> However, you can't select python (or any other options) without
> checking that their needed dependencies are fulfilled.

Yup, got it ;-), thanks for insight (and for fixing it)!

Regards,
Peter

> >
> > Regards,
> > Peter
> >
> >  
> > > >     help
> > > >       Install the smb tools smbinfo and smb2-quota (python
> > > >       implementations).
> > > >
> > > > +comment "smbtools needs a toolchain w/ wchar, threads, dynamic library"
> > > > +   depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
> > > > +           BR2_STATIC_LIBS
> > > > +
> > > >  endif
> > > > --
> > > > 2.30.2
> > > >
> > > > _______________________________________________
> > > > buildroot mailing list
> > > > buildroot at busybox.net
> > > > http://lists.busybox.net/mailman/listinfo/buildroot  
> > >  
> >  
> Best Regards,
> 
> Fabrice
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot