[Buildroot] [PATCH] Makefile: be careful what we remove from saved defconfig

Sven Oliver Moll buildroot at svol.li
Fri Oct 23 17:35:35 UTC 2020


On Fri, 23 Oct 2020, Hervé CODINA wrote:

> Maybe I acked too quickly ...
>
> What do you think about this pattern
> @$(SED) '/^BR2_DEFCONFIG=/d' -e '/^# BR2_DEFCONFIG /
> in order to match "BR2_DEFCONFIG=xxxxxxxx" and "# BR2_DEFCONFIG is not set" ?
[...]

I don't think that this is necessary, because savedefconfig only saves the 
ones that are different from preset. So:
- BR2_DEFCONFIG is the name to save to, so an unset instance does not exist
   (a bit like chicken and egg)
- BR2_DL_DIR, when unset, will not appear as "# BR2_DL_DIR is unset" in the
   saved *_defconfig
...or am I missing something?


Greetings,
SvOlli
-- 
|  _______       |
| (  /\          |
|__)v\/lli a.k.a.| Be good, but not TOO good.
|Sven Oliver Moll|   -- Frumpy The Clown by Judd Winick (Final: June, 7th 1998)


More information about the buildroot mailing list