[Buildroot] [PATCH 1/1] package/pistache: force Release mode

Fabrice Fontaine fontaine.fabrice at gmail.com
Sat Oct 17 13:05:25 UTC 2020


Le sam. 17 oct. 2020 à 14:56, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
>
> On Sat, 16 May 2020 14:19:35 +0200
> Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:
>
> > +# Force Release to fix build failure without SSP
> > +PISTACHE_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release
>
> In some packages, we use CMAKE_BUILD_TYPE=Buildroot, and in others
> CMAKE_BUILD_TYPE=Release. Should we take a decision on which one makes
> the most sense ?
Release is a standard cmake value
(https://cmake.org/cmake/help/v3.0/variable/CMAKE_BUILD_TYPE.html). It
is "forced" in 5 packages.
Buildroot is not standard and is used by only 2 packages.
So I would vote for Release.
More globally, perhaps we should always set CMAKE_BUILD_TYPE to
Release in pkg-cmake independently of the BR2_ENABLE_DEBUG value.
This would allow us to remove all those workarounds.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice


More information about the buildroot mailing list