[Buildroot] [PATCH] package/apparmor: fix permission bits for apparmor.service

[Stefan Agner]

On 2020-11-12 21:42, Stefan Agner wrote:
> On 2020-11-12 21:26, Thomas Petazzoni wrote:
>> Hello Stefan,
>>
>> Thanks for your patch!
>>
>> On Thu, 12 Nov 2020 21:21:34 +0100
>> Stefan Agner <stefan at agner.ch> wrote:
>>
>>> Avoid setting executable bits for apparmor.service. This gets rid of a
>>> corresponding warning during installation:
>>>   Configuration file ../target/usr/lib/systemd/system/apparmor.service
>>>   is marked executable. Please remove executable permission bits.
>>>   Proceeding anyway.
>>>
>>> Signed-off-by: Stefan Agner <stefan at agner.ch>
>>> ---
>>>  package/apparmor/apparmor.mk | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/package/apparmor/apparmor.mk b/package/apparmor/apparmor.mk
>>> index 4d08b0433b..7ea0fabd91 100644
>>> --- a/package/apparmor/apparmor.mk
>>> +++ b/package/apparmor/apparmor.mk
>>> @@ -88,7 +88,7 @@ endef
>>>  define APPARMOR_INSTALL_INIT_SYSTEMD
>>>  	$(INSTALL) -D -m 0755 $(@D)/parser/apparmor.systemd \
>>>  		$(TARGET_DIR)/lib/apparmor/apparmor.systemd
>>
>> Any reason not to change this one as well ?
> 
> Hm, I somehow thought this is a directory. But it is actually a script
> which afaik only gets included, so I guess we can take away executable
> as well.

No it is actually executed by the systemd service:
apparmor.service:ExecStart=/lib/apparmor/apparmor.systemd reload

So this needs executable bits.

--
Stefan