[Buildroot] [PATCH v2] package/cvs: fix mktime related compile failure

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri May 29 19:07:05 UTC 2020


On Fri, 29 May 2020 20:43:43 +0200
Peter Seiderer <ps.report at gmx.net> wrote:

> > With the time_t conversion to 64bit, time_t *is* larger than an
> > unsigned int.
> >
> > So aren't you papering over the problem, and in fact potentially
> > causing some issues in CVS, which seems to assume the time_t fits in
> > 32-bit ?  
> 
> ....it is only the internal assumption of the local mktime implementation,
> as far as I see all cvs callers of mktime use time_t to store the return
> value....

Hm, ok. But does it make sense to use the AlpineLinux patch instead ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list