[Buildroot] [PATCH 1/1] package/linuxptp: remove hardcoded interface from config to args

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon May 25 07:40:05 UTC 2020


Hello,

On Thu, 21 May 2020 22:52:07 +0200
Heiko Thiery <heiko.thiery at gmail.com> wrote:

> > Well, you can also just as well provide your custom linuxptp.cfg in a
> > rootfs overlay, no?
> 
> Yes this is for sure a valid solution. You mean it doesn't matter
> adding a custom linuxptp.cfg or a /etc/defaults/ptp4l to change the
> interface to be used because both ways need to add a file to the
> rootfs overlay?

Exactly what I meant indeed.

> > Also, your change to linuxptp.cfg kind of breaks what is explained in
> > linuxptp.cfg:
> 
> I think it does not break the functionality. The patch only changes
> the location of the interface to be used. ptp4l can set the interface
> either in the config or in the arguments.

No, it does not break the functionality, but the explanation in the
comment becomes a bit weird, as the fact that eth0 is used is no longer
configured through that config file.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list