[Buildroot] [PATCH v3 3/9] package/collectd: depend on luainterpreter for lua support

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon May 25 07:10:50 UTC 2020


On Sun, 24 May 2020 18:48:39 -0600
James Hilliard <james.hilliard1 at gmail.com> wrote:

>  config BR2_PACKAGE_COLLECTD_LUA
>  	bool "lua"
> -	select BR2_PACKAGE_LUA
> +	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
>  	help
>  	  Embeds a Lua interpreter into collectd and provides an
>  	  interface to collectd's plugin system.
>  
> +comment "lua needs a Lua interpreter"
> +	depends on !BR2_PACKAGE_HAS_LUAINTERPRETER

I believe this comment is not needed, it is obvious a Lua interpreter
is needed for Lua support.

> -	$(if $(BR2_PACKAGE_COLLECTD_LUA),lua) \
> +	$(if $(BR2_PACKAGE_COLLECTD_LUA),$(if $(BR2_PACKAGE_LUA),lua,luajit)) \

Use the luainterpreter virtual package as a dependency here.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list