[Buildroot] [PATCH 3/3] configs/nitrogen8mm: Add new defconfig
gary.bisson at boundarydevices.com
Fri Mar 27 09:55:36 UTC 2020
On Thu, Mar 26, 2020 at 09:57:14PM +0100, Thomas Petazzoni wrote:
> Hello Gary,
> I was about to apply, but there are a few things that could be
> improved. See below.
> On Thu, 26 Mar 2020 15:44:36 +0100
> Gary Bisson <gary.bisson at boundarydevices.com> wrote:
> > NXP i.MX8MMini based SBC with 2GB of LPDDR4 and 8GB eMMC.
> > More details on the platform here:
> > https://boundarydevices.com/product/nitrogen8m-mini
> > Signed-off-by: Gary Bisson <gary.bisson at boundarydevices.com>
> > ---
> > configs/nitrogen8mm_defconfig | 56 +++++++++++++++++++++++++++++++++++
> > 1 file changed, 56 insertions(+)
> > create mode 100644 configs/nitrogen8mm_defconfig
> Could you update board/boundary/common/readme.txt to also list this
> platform as being supported, and any other note that might be relevant ?
Yes good catch I'll make sure to update it.
> > +BR2_TARGET_GENERIC_GETTY=y
> > +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc1"
> > +BR2_ROOTFS_POST_BUILD_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/boundarydevices/common/post-build.sh"
> > +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/boundarydevices/common/post-image.sh"
> Could you drop this script and use support/scripts/genimage.sh ?
> Indeed, it does the same thing, and in fact support/scripts/genimage.sh
> got fixed to use an empty rootpath and avoid a useless extra copy
> (commit 31d1fb27b0e62a6542112a7476ff188f2f7b8d38).
Sure will do, didn't know about that script ;)
> It would be good to do that in a preparation commit for all existing
> Boundary Devices boards.
Yep I'll align all boards to use that script.
More information about the buildroot