[Buildroot] [PATCH] package/syslog-ng: fix build if net-snmp is installed on the host

Thomas De Schampheleire patrickdepinguin at gmail.com
Wed Mar 18 19:50:41 UTC 2020


El mar., 17 mar. 2020 a las 0:23, Chris Packham
(<judge.packham at gmail.com>) escribió:
>
> Hi Thomas,
>
> On Tue, Mar 17, 2020 at 4:00 AM Thomas De Schampheleire
> <patrickdepinguin at gmail.com> wrote:
> >
> > From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> >
> > If syslog-ng is selected in Buildroot and net-snmp is not, but net-snmp is
> > found on the host machine (at least its net-snmp-config script) then
> > compilation of syslog-ng fails with:
> >
> >   CC       modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo
> >   CC       modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo
> >   CC       modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.lo
> > arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include'
> > make[3]: *** [Makefile:17397: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-grammar.lo] Error 1
> > make[3]: *** Waiting for unfinished jobs....
> > arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include'
> > make[3]: *** [Makefile:17404: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest.lo] Error 1
> > arm-none-linux-gnueabi-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include'
> > make[3]: *** [Makefile:17411: modules/snmp-dest/modules_snmp_dest_libsnmpdest_la-snmpdest-plugin.lo] Error 1
> > make[2]: *** [Makefile:21428: all-recursive] Error 1
> > make[1]: *** [Makefile:8740: all] Error 2
> > make[1]: Leaving directory '.../buildroot/output/build/syslog-ng-3.25.1'
> > make: *** [package/pkg-generic.mk:269: .../buildroot/output/build/syslog-ng-3.25.1/.stamp_built] Error 2
> >
> > The path /usr/include is obtained via /usr/bin/net-snmp-config.
> >
> > The fix comprises two parts:
> > 1. only enable net-snmp support in syslog-ng if the net-snmp package is
> > enabled in Buildroot
> > 2. for the case where net-snmp is selected in Buildroot, fix the configure
> > script of syslog-ng to allow parsing --with-netsnmp=<path> correctly.
> >
> > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
>
> One comment below, regardless
>
> Reviewed-by: Chris Packham <judge.packham at gmail.com>
>
> > ---
> >  .../0002-configure.ac-fix-with-netsnmp.patch  | 41 +++++++++++++++++++
> >  package/syslog-ng/syslog-ng.mk                |  8 ++++
> >  2 files changed, 49 insertions(+)
> >  create mode 100644 package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch
> >
> > diff --git a/package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch b/package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch
> > new file mode 100644
> > index 0000000000..f5b2a39bba
> > --- /dev/null
> > +++ b/package/syslog-ng/0002-configure.ac-fix-with-netsnmp.patch
> > @@ -0,0 +1,41 @@
> > +From 39ab118a7e79b223941b50b372c8ed51f0e21f4b Mon Sep 17 00:00:00 2001
> > +From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> > +Date: Mon, 16 Mar 2020 15:41:03 +0100
> > +Subject: [PATCH] configure.ac: fix --with-netsnmp
> > +
> > +The option '--with-net-snmp' did not work, because later checks were using
> > +the variable '$with_netsnmp' rather than '$with_net_snmp'.
> > +
> > +There are two possible solutions:
> > +- make the option '--with-netsnmp'
> > +- change the internal variables
> > +
> > +Taking into account that latest upstream has moved away from autotools and
> > +towards cmake, we opt for the first option that has the least amount of
> > +changes.
> > +
> > +Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> > +Upstream-status: not applicable (latest upstream moved to cmake)
>
> Actually upstream are supporting both cmake and autotools so it's
> probably worth submitting.
>


Thanks, I had misunderstood it.
I now sent a patch upstream, although in light of this
misunderstanding I opted to fix the --with-net-snmp option instead of
renaming it to --with-netsnmp. As a result, if the patch is accepted
upstream, we'll have to update Buildroot accordingly too.

https://github.com/syslog-ng/syslog-ng/pull/3180


More information about the buildroot mailing list