[Buildroot] [PATCH 1/2] package/freescale-imx: Add option for all i.MX FW needs

Stephane Viau (OSS) stephane.viau at oss.nxp.com
Mon Jun 29 06:38:36 UTC 2020


Yann, Sebastien, all,

>> Thomas wrote:                                                                 
>> >However, I am wondering if package/freescale-imx/Config.in is the right      
>> >place for all this logic. After all, this is only related to the             
>> >firmware-imx package.                                                        
>> >                                                                             
>> >Shouldn't we instead move that to                                            
>> >package/freescale-imx/firmware-imx/Config.in, with the following form:       
>> >                                                                             
>> >config BR2_PACKAGE_FREESCALE_IMX_NEEDS_DDR_FW                                
>> >        bool                                                                 
>> >        default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M                
>> >        default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM               
>> >        default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN               
>> >                                                                             
>> >and ditto the other options ? Here as well, it would require a               
>> >preparation patch to take care of the NEEDS_DDR_FW case, and then your       
>> >patch that handles all other FW files.                                       
>>                                                                               
>> I'd like to have Yann's and/or Gary's feedback on this. I'm using 'select' based on this comment:
>> "                                                                             
>>   As Yann mentioned on IRC:                                                   
>>   "Usually, when we introduce such option, it does not 'default y' based      
>>   on some other options. Instead, the other options 'select' it."             
>> "                                                                             
>> from http://lists.busybox.net/pipermail/buildroot/2020-May/283180.html        
>                                                                                
>True, that's what I said. That was based on the assumption that the             
>options would be in package/freescale-imx/Config.in.                            
>                                                                                
>But now, seeing the reasonning by Thomas, I agree with him: those are           
>better suited to live in package/freescale-imx/firmware-imx/Config.in/          
>                                                                                
>And thus it is less clean that the variant selection in the generic             
>choice would have to catter with options specific to a package.                 
>                                                                                
>Hence, the "default y if ..." is indeed better.                                 
>                                                                                
>Sorry I did not have that insight to begin with...                              

No worries ; thank you all for your comments!
Will send out a v2 soon..

BTW, I'm also thinking of embedding the 'install path' fix proposed by Sebastien here:
http://lists.busybox.net/pipermail/buildroot/2020-June/284875.html 

BR,
Stephane. 
                                                                                 
>                                                                                
>Regards,                                                                        
>Yann E. MORIN.                                                                  
>                                                                                
>--                                                                              
>.-----------------.--------------------.------------------.--------------------.
>|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
>| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
>| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
>| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
>'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list