[Buildroot] [PATCH 4/4] package/lttng-{libust, tools}: use proper systemd rundir

Norbert Lange nolange79 at gmail.com
Sat Jun 27 19:32:11 UTC 2020


Thomas Petazzoni <thomas.petazzoni at bootlin.com> schrieb am Sa., 27. Juni
2020, 16:46:

> On Sat, 27 Jun 2020 00:06:02 +0200
> Norbert Lange <nolange79 at gmail.com> wrote:
>
> > Set the rundir to /run/lttng, if systemd is the init system.
> > /var/run is "legacy" in systemd's view.
> >
> > Perhaps a better way would be to define a variable
> > BR2_PACKAGE_RUNDIR to /var/run or /run depending on ini system.
> > (systemd will for example issue warnings for the dbus service,
> > using a socket in /var/run)
>
> I've dropped this paragraph, since it doesn't really belong in the
> commit message itself.
>
> Is there a reason to still use /var/run in non-systemd systems ?
>

Not that i know of, it is still the default in packages, but I believe this
it paranoid compatibility for ancient systems. Not something you should
care about on new ones.

>
> >  ifeq ($(BR2_PACKAGE_PYTHON),y)
> >  LTTNG_LIBUST_DEPENDENCIES += python
> >  LTTNG_LIBUST_CONF_OPTS += --enable-python-agent
> > diff --git a/package/lttng-tools/lttng-tools.mk b/package/lttng-tools/
> lttng-tools.mk
> > index b1b0a24a4f..0f3dc84ebd 100644
> > --- a/package/lttng-tools/lttng-tools.mk
> > +++ b/package/lttng-tools/lttng-tools.mk
> > @@ -13,6 +13,10 @@ LTTNG_TOOLS_LICENSE_FILES = LICENSE $(addprefix
> LICENSES/,BSD-2-Clause BSD-3-Cla
> >  LTTNG_TOOLS_CONF_OPTS += --disable-man-pages
> >  LTTNG_TOOLS_DEPENDENCIES = liburcu libxml2 popt util-linux
> >
> > +ifeq ($(BR2_INIT_SYSTEMD),y)
> > +LTTNG_LIBUST_CONF_OPTS += --with-lttng-system-rundir=/run/lttng
>
> You're using LTTNG_LIBUST_CONF_OPTS, but it should have been
> LTTNG_TOOLS_CONF_OPTS.
>
> I fixed that when applying. Thanks!
>
Ok, thanks


> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200627/f1f3c3f8/attachment.html>


More information about the buildroot mailing list