[Buildroot] [PATCH v2] package/irrlicht: fix libraries linking

Bartosz Biłas b.bilas at grinn-global.com
Wed Jun 24 08:27:35 UTC 2020


Hi Thomas,

On 6/24/20 10:05 AM, Thomas Petazzoni wrote:
> On Tue, 23 Jun 2020 20:08:47 +0200
> Bartosz Bilas <b.bilas at grinn-global.com> wrote:
>
>>>> Due to the fact that it points to the host system libraries. This -L
>>>> argument is set correctly within package makefile.
>>> Yes, of course. My question is why do you have two patches? They touch
>>> exactly the same line, simply do the change in two steps instead of
>>> one. Am I missing something here ?
>> Ah, I didn't want to combine everything into one patch because there
>> were 2 different changes (adding keyword and removing paths) but I'm
>> gonna combine it into one patch then.
> OK, it's true you can see it as: one allows to override the LDFLAGS,
> the other drops a bogus hardcoded path.
>
>
>>>>> IRRLICHT_CONF_OPTS += CPPFLAGS="$(IRRLICHT_CPPFLAGS)"
>>>> Good hint, I was thinking about a bit different approach but it wasn't
>>>> working as I expected therefore I did it as it's above.
>>> So I guess you'll rework accordingly? If needed, you can also have a
>>> preparation patch that reworks this IRRLICHT_CPPFLAGS thing for the
>>> NEON stuff, and then another patch that fixes the library linking issue.
>>>
>>> Thomas
>> It turned out that -I$(STAGING_DIR)/usr/include isn't necessary anymore
>> so I've decided not to touch that.
> -I$(STAGING_DIR)/usr/include is definitely useless as it's the default 
> search path for headers for the Buildroot cross-compiler, but that's 
> not what you were adding: you were adding 
> -I$(STAGING_DIR)/usr/include/X11R6, which is not in the default search 
> path for headers. Best regards, Thomas
No, previously I was adding -I$(STAGING_DIR)/usr/include/X11 but this 
path wasn't necessary therefore in the v3 there is no this path anymore.
This -I$(STAGING_DIR)/usr/include/X11R6 path was the default one which 
I've removed from the makefile.

I hope that everything is clear now ;)

Best
Bartek


More information about the buildroot mailing list