[Buildroot] [PATCH v2 3/7] package/cups: bump to version 2.3.3

Angelo Compagnucci angelo.compagnucci at gmail.com
Sat Jun 20 21:53:12 UTC 2020


Il sab 20 giu 2020, 22:55 Thomas Petazzoni <thomas.petazzoni at bootlin.com>
ha scritto:

> On Sat, 20 Jun 2020 22:48:55 +0200
> Angelo Compagnucci <angelo at amarulasolutions.com> wrote:
>
> > It's really that important to split it? No problem to do that, but this
> > package installs a service and the way it is doing in the new version is
> > the one proposed in the patch. The old version could have been different,
> > I've not checked btw.
> > Anyway, having this is required to have the service correctly installed,
> so
> > I don't think the patch should be splitted because the bump really
> requires
> > it.
>
> How is this related to the bump? Is it the version bump that adds the
> service file? Or did it already exist before the bump?
>

Cups is a service and a service without an init script is useless.

So, to have the new version working it needs the rcdir change and the
systemv script. Systemd script is instead fine.

If you are asking me to even fix the older version I can do that, but I'm
doing a bump and fixing at the same time because either the bump will not
work.



> > > > +define CUPS_INSTALL_INIT_SYSV
> > > > +     @$(RM) $(TARGET_DIR)/etc/init.d/cups
> > >
> > > This should also be done in the systemd case I believe, and should not
> > > have the @.
> > >
> >
> > Not for systemd, cause the package installs the .service file and not the
> > systemv related ones.
>
> OK, I see: when --enable-systemd is used to build cups, it doesn't
> install its own init script. Makes sense. Thanks for explaining this
> aspect!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200620/4e5b9534/attachment.html>


More information about the buildroot mailing list