[Buildroot] [PATCH v2 1/7] package/dejavu: Install dejavu fonts in staging dir

Michael Nazzareno Trimarchi michael at amarulasolutions.com
Sat Jun 20 20:37:03 UTC 2020


Hi

On Sat, Jun 20, 2020 at 10:29 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello Angelo,
>
> On Fri, 19 Jun 2020 16:57:13 +0200
> Angelo Compagnucci <angelo at amarulasolutions.com> wrote:
>
> > From: Michael Trimarchi <michael at amarulasolutions.com>
> >
> > The dejavu font is used by cups-filters and needs to be
> > installed in staging directory.
> >
> > Signed-off-by: Michael Trimarchi <michael at amarulasolutions.com>
> > Signed-off-by: Angelo Compagnucci <angelo at amarulasolutions.com>
>
> The question is why should we do this just for the DejaVu fonts ? And
> not other font packages ?

Ok, optional can be created a patch to remove this dependency that is used
to compile tests.

Michael

>
> > +define DEJAVU_INSTALL_STAGING_CMDS
> > +     mkdir -p $(STAGING_DIR)/usr/share/fonts/dejavu/
> > +     for i in $(DEJAVU_FONTS_INSTALL) ; do \
> > +             $(INSTALL) -m 0644 $(@D)/ttf/$$i \
> > +                     $(STAGING_DIR)/usr/share/fonts/dejavu/ || exit 1 ; \
> > +     done
> > +endef
> > +
> >  define DEJAVU_INSTALL_TARGET_CMDS
> >       mkdir -p $(TARGET_DIR)/usr/share/fonts/dejavu/
> >       for i in $(DEJAVU_FONTS_INSTALL) ; do \
>
> We could factorize things a bit between staging/target installation,
> and perhaps use a make "foreach" loop (if that works). But really these
> are minor details, the main question is: why DejaVu specifically.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |


More information about the buildroot mailing list