[Buildroot] [PATCH 2/2] core/br2-external: report better error messages

Romain Naour romain.naour at gmail.com
Sun Jun 14 15:33:48 UTC 2020


Le 22/05/2020 à 23:40, Yann E. MORIN a écrit :
> The error is misleading: it reports that no name was provided,
> when in fact the external.desc file is missing.


Reviewed-by: Romain Naour <romain.naour at gmail.com>

Best regards,
Romain

> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>p
> ---
>  support/scripts/br2-external | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/scripts/br2-external b/support/scripts/br2-external
> index fdea5aa251..ededd2d900 100755
> --- a/support/scripts/br2-external
> +++ b/support/scripts/br2-external
> @@ -75,7 +75,7 @@ do_validate_one() {
>          error "'%s': permission denied\n" "${br2_ext}"
>      fi
>      if [ ! -f "${br2_ext}/external.desc" ]; then
> -        error "'%s': does not have a name (in 'external.desc'). See %s\n" \
> +        error "'%s': does not have an 'external.desc'. See %s\n" \
>              "${br2_ext}" "${MANUAL_URL}"
>      fi
>      br2_name="$(sed -r -e '/^name: +(.*)$/!d; s//\1/' "${br2_ext}/external.desc")"
> 



More information about the buildroot mailing list