[Buildroot] [PATCH 1/1] python-pybind: new package

Guillaume Bres guillaume.bressaix at gmail.com
Fri Jun 12 07:54:41 UTC 2020


Sorry for the double post, but replace 'pushing a v2' by 'pushing a fix',
because the package is included in the tree since yesterday, and it
contains Thomas's rework of the patch

Guillaume W. Bres
Software engineer
<guillaume.bressaix at gmail.com>


Le ven. 12 juin 2020 à 09:42, Guillaume Bres <guillaume.bressaix at gmail.com>
a écrit :

> Hello,
>
> If I understand correctly, this patch only covers the first use case
> (C++/Python). I only added this one because my following patch requires
> host-python-pybind, but I agree it certainly lacks a depends on
> !BR2_INSTALL_LIBSTDCPP. I'll wait for people's point of view before going
> any further anyway. If you agree on this, I will add the dependency and
> push a *v2*
>
> The other use case that people might need in the future, is not allowed at
> the moment until we unlock it with $(eval $(cmake-package)) but requires
> further work (I am also not familiar with cmake at the moment). Maybe you
> could proceed with adding the cmake support because you are knowledgeable
> and already got it working?
>
> One last question though: "For example, this project won't find pybind11
> because it uses find_package(pybind11...)", so we should rename the package
> to *python-pybind11*? so we don't have any other problems when unlocking
> the cmake option. If you agree on that point, my v2 will be renamed to
> *python-pybind11* & and I will also adapt my following work to this new
> name
>
> Guillaume W. Bres
> Software engineer
> <guillaume.bressaix at gmail.com>
>
>
> Le jeu. 11 juin 2020 à 20:14, Asaf Kahlon <asafka7 at gmail.com> a écrit :
>
>> Hello,
>>
>> I'm not sure pybind11 is just a "regular" python package.
>> First, it needs C++11 so we have to make sure the toolchain supports
>> that in order to be able to actually compile the generated pybind11
>> code.
>> Secondly, the installation through setup.py just installs the pybind11
>> headers and it doesn't give any way for C++ projects to locate the
>> package. For example, this project won't find pybind11 because it uses
>> find_package(pybind11...) in it's CMakeLists.txt:
>> https://github.com/pybind/pybind11_json. The installation of pybind11
>> using CMake gives a solution to this problem.
>>
>> Those considerations have been taken into account in a previous patch
>> I sent to the mailing list few weeks ago:
>>
>> https://patchwork.ozlabs.org/project/buildroot/patch/20200513183903.8656-1-asafka7@gmail.com/
>>
>> Regards,
>> Asaf.
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200612/94bc2dbf/attachment.html>


More information about the buildroot mailing list