[Buildroot] [PATCH] package/haveged: Allow service to run early
jeremy.rosen at smile.fr
Sun Jun 7 19:05:27 UTC 2020
Le dim. 7 juin 2020 à 20:35, Norbert Lange <nolange79 at gmail.com> a écrit :
> Am So., 7. Juni 2020 um 12:35 Uhr schrieb Jérémy ROSEN <
> jeremy.rosen at smile.fr>:
> > Le sam. 6 juin 2020 à 00:55, Norbert Lange <nolange79 at gmail.com> a
> écrit :
> >> Drop default dependencies, haveged needs nothing but
> >> local sockets and /dev/random.
> >> This allows the entropy to be available earlier.
> >> Signed-off-by: Norbert Lange <nolange79 at gmail.com>
> >> ---
> >> package/haveged/haveged.service | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >> diff --git a/package/haveged/haveged.service
> >> index 91035c6711..ed9f043a91 100644
> >> --- a/package/haveged/haveged.service
> >> +++ b/package/haveged/haveged.service
> >> @@ -1,10 +1,13 @@
> >> [Unit]
> >> Description=Entropy Harvesting Daemon
> >> Documentation=man:haveged(8)
> >> +DefaultDependencies=no
> >> +Conflicts=shutdown.target
> >> +Before=sysinit.target shutdown.target systemd-update-done.service
> > Since v243 (quoting systemd's NEWS file) :
> > * systemd-random-seed.service is now a synchronization point for full
> > initialization of the kernel's entropy pool. Services that
> > /dev/urandom to be correctly initialized should be ordered
> after this
> > service.
> > so... in that case it might make sense to add
> > (assuming that works. This a very early point, so it needs some testing)
> No, doesnt make sense, a "before" only means the service is *started
> not the process did do anything worthwile. (That's the reason for my
> openssh patch BTW)
> systemd-random-seed.service is a one-shot, so a "before" *that*
> service means the dependants wait till it is finished.
> (note that I don't really understand what haveged does, so I might be
completely wrong in my
systemd-random-seed is the sync point, that means that any service that
random numbers should be ordered after random-seed.
So, to me, it makes sense that we want to have haveged started before that
having haveged ordered before random-seed.
and I don't really understand your sentence above...
if you add Before=systemd-random-seed, it's systemd-random-seed that will
haveged to be started, not the other way round. (which seems to be what you
now... if haveged needs some time to "do something usefull" then it means
is badly synchronised on startup. The Ready signal in systemd is defined as
at which the service is able to render the service expected for it'
> >> [Service]
> >> ExecStart=/usr/sbin/haveged -F -w 1024 -v 1
> >> SuccessExitStatus=143
> > I could not find any documentation on haveged return codes, so i'll
> trust you on that one
> Don't trust me, I did not touch the values (but I can attest they work).
> >> [Install]
> >> -WantedBy=multi-user.target
> >> +WantedBy=sysinit.target
> >> --
> >> 2.26.2
> > Apart from my earlier remark, you can add my ReviewedBy
[image: SMILE] <http://www.smile.eu/>
20 rue des Jardins
[image: email] jeremy.rosen at smile.fr
[image: phone] +33 6 88 25 87 42
[image: url] http://www.smile.eu
[image: Twitter] <https://twitter.com/GroupeSmile> [image: Facebook]
<https://www.facebook.com/smileopensource> [image: LinkedIn]
<https://www.linkedin.com/company/smile> [image: Github]
[image: Découvrez l’univers Smile, rendez-vous sur smile.eu]
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the buildroot