[Buildroot] [PATCH 2/2] package/dbus: remove /usr/lib/dbus-1.0 if empty

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Jun 7 08:45:49 UTC 2020


Hello Norbert,

On Sun, 7 Jun 2020 00:36:47 +0200
Norbert Lange <nolange79 at gmail.com> wrote:

> > Your Signed-off-by is missing, and there is no commit log. We clearly
> > need a better explanation. And your commit title is wrong: you're not
> > just removing /usr/lib/dbus-1.0 is empty: you're changing from removing
> > it unconditionally to removing just /usr/lib/dbus-1.0/include and then
> > removing /usr/lib/dbus-1.0 if it's empty.  
> 
> Ok, gonna improve that in a v2 if you find no other objections

My main objection is that we need a better commit log.

> > So it means that you have installed *something* in /usr/lib/dbus-1.0
> > that you want Buildroot to keep on the target. But what? This is not
> > explained in your commit log.  
> 
> I wrote this commit some months ago, would have to outright lie, but I
> think it was dbusbroker (patch on the ML).
> The basic gist is, that /usr/lib/dbus-1.0 is some sort of libexec dir
> (on Debian and Fedora AFAIK), and I believe dbusbroker installs it
> stuff there.
> 
> What we really want is to remove the unneeded files (the includes),
> and the parent directory it is empty.

Could you verify what dbusbroker installs in this directory, explain
why it is relevant, and use that as a justification in the commit log ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list