[Buildroot] [PATCH] package/prosody: fix dependency
Yann E. MORIN
yann.morin.1998 at free.fr
Tue Jul 28 20:25:11 UTC 2020
François, All,
On 2020-07-28 11:21 +0200, François Perrad spake thusly:
> Le mar. 28 juil. 2020 à 09:21, Thomas Petazzoni < [1]thomas.petazzoni at bootlin.com> a écrit :
> > LuaBitOp is not available with Lua 5.3
> The commit log is probably not very clear. Indeed, if LuaBitOp is not
> available with Lua 5.3, one would think you would need the external
> BR2_PACKAGE_LUABITOP when using something else than 5.1, i.e the
> opposite of what your change is doing.
>
> Shouldn't the commit log rather be:
>
> The luabitop functionality is available built-in in Lua 5.3 and
> LuaJIT, so only Lua 5.1 needs the additional external luabitop
> package.
>
> Could you confirm ?
>
> bitwise operators are built-in in Lua 5.3,
> LuaBitOp is a built-in library in LuaJIT,
> so only Lua 5.1 needs the additional external LuaBitOp package.
OK, thanks for the explanations.
However, luabitop depends on !lua-5.3, and I see in your latest series
that you extended the dependency to !lua-5.4. Maybe we should also
fix that, no?
That is, we should have:
config BR2_PACKAGE_LUABITOP
depends on BR2_PACKAGE_LUA_5_1
However, you are saying (emphasize mine):
"only Lua 5.1 **needs** the additional external LuaBitOp"
Does that mean that it can still be used with other versions of Lua?
That is, if we are using lua-5.3, and a package selects luabitop, will
this fail to build? To run? In other words, is it a problem if a pacakge
ends up using luabitop on another version of lua?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list