[Buildroot] [PATCH] package/prosody: fix dependency

[Thomas Petazzoni]

On Tue, 28 Jul 2020 08:21:40 +0200
Francois Perrad <fperrad at gmail.com> wrote:

> LuaBitOp is not available with Lua 5.3
> 
> Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
> ---
>  package/prosody/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/prosody/Config.in b/package/prosody/Config.in
> index 4b7ea9425..bb3a5025f 100644
> --- a/package/prosody/Config.in
> +++ b/package/prosody/Config.in
> @@ -3,7 +3,7 @@ config BR2_PACKAGE_PROSODY
>  	depends on BR2_USE_MMU # fork
>  	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
>  	depends on !BR2_STATIC_LIBS # luaexpat, luasec, luasocket, luafilesystem
> -	select BR2_PACKAGE_LUABITOP if !BR2_PACKAGE_LUAJIT # runtime
> +	select BR2_PACKAGE_LUABITOP if BR2_PACKAGE_LUA_5_1 # runtime

The commit log is probably not very clear. Indeed, if LuaBitOp is not
available with Lua 5.3, one would think you would need the external
BR2_PACKAGE_LUABITOP when using something else than 5.1, i.e the
opposite of what your change is doing.

Shouldn't the commit log rather be:

  The luabitop functionality is available built-in in Lua 5.3 and
  LuaJIT, so only Lua 5.1 needs the additional external luabitop
  package.

Could you confirm ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com