[Buildroot] [PATCH v2] package/cdrkit: fix build with GCC 10
Urja Rannikko
urjaman at gmail.com
Sun Jul 19 17:42:36 UTC 2020
This patch adds a missing extern on the outfile
variable in genisoimage.h.
Signed-off-by: Urja Rannikko <urjaman at gmail.com>
---
Note: I would like to see this applied to the LTS 2020.02
branch too, since it fixes building host-cdrkit for ISO9660
generation with a host GCC 10.
v2: Make the patch a fully fledged commit with a sign-off and
way more description than is necessary for a single "extern".
...ar-outfile-declaration-to-fix-build-.patch | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
diff --git a/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch b/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
new file mode 100644
index 0000000000..30f4c8d01d
--- /dev/null
+++ b/package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
@@ -0,0 +1,30 @@
+From eabcc8a6e39dc3c28faee3e04aa56cc65a38d65a Mon Sep 17 00:00:00 2001
+From: Urja Rannikko <urjaman at gmail.com>
+Date: Sun, 19 Jul 2020 20:28:27 +0300
+Subject: [PATCH] Add extern to char* outfile declaration to fix build with gcc
+ 10
+
+Without this linking fails with a rather long spew of
+"multiple definition of `outfile'".
+
+Signed-off-by: Urja Rannikko <urjaman at gmail.com>
+---
+ genisoimage/genisoimage.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h
+index bbedfb0..82c859b 100644
+--- a/genisoimage/genisoimage.h
++++ b/genisoimage/genisoimage.h
+@@ -376,7 +376,7 @@ extern int use_fileversion;
+ extern int split_SL_component;
+ extern int split_SL_field;
+ extern char *trans_tbl;
+-char *outfile;
++extern char *outfile;
+
+ #define JMAX 64 /* maximum Joliet file name length (spec) */
+ #define JLONGMAX 103 /* out of spec Joliet file name length */
+--
+2.27.0
+
--
2.27.0
More information about the buildroot
mailing list