[Buildroot] [PATCH] package/freescale-imx/firmware-imx: fix sdma support for imx8m family

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Jul 16 14:07:45 UTC 2020


On Thu, 16 Jul 2020 15:52:50 +0200
Gary Bisson <gary.bisson at boundarydevices.com> wrote:

> > Thanks for looking into this. Another possible solution if we have more
> > of this in the future (we already have it for vpu and sdma) would be to
> > drop the NEEDS_XYZ_FW options and instead do this:
> > 
> > config BR2_PACKAGE_FIRMWARE_IMX_VPU_FW_NAME
> > 	string
> > 	default "imx53" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53
> > 	default "imx7d" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
> > 	default "imx7d" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM
> > 	default "imx7d" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN
> > 
> > and then in the .mk file, we rely on
> > BR2_PACKAGE_FIRMWARE_IMX_VPU_FW_NAME being empty or not to decide
> > whether the VPU firmware should be installed. And because this variable
> > is not just a boolean, it also tells us what is the firmware name.  
> 
> Yes it looks like a better option, we could even do the same for VPU
> then.
> Are we all ok with such approach?

I think it doesn't add more lines, and will avoid the calculation of
FIRMWARE_IMX_PLATFORM_LOWER.

> Note the '*' which makes everything works ;)
> That is why imx7 will properly the imx7d binary and the imx27 will copy
> the imx27_TO2 one.

Ah indeed, and that's another thing we could get rid of with the
proposal above, as we would have the exact firmware name.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list