[Buildroot] [PATCH 1/2] sdl_mixer: add FluidSynth support
Paul Cercueil
paul at crapouillou.net
Sun Jul 12 17:39:36 UTC 2020
Hi Thomas,
Le dim. 12 juil. 2020 à 15:56, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
> On Thu, 2 Jul 2020 17:25:46 +0200
> Paul Cercueil <paul at crapouillou.net> wrote:
>
>> Add support for MIDI playback using FluidSynth.
>>
>> Signed-off-by: Paul Cercueil <paul at crapouillou.net>
>> ---
>> package/sdl_mixer/sdl_mixer.mk | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>
> I've applied both patches, but I've changed a bit how the .mk file
> handles the option. After both patches, it looks like this:
>
> ifeq ($(BR2_PACKAGE_FLUIDSYNTH),y)
> SDL_MIXER_DEPENDENCIES += fluidsynth
> SDL_MIXER_CONF_OPTS += \
> --enable-music-midi \
> --enable-music-fluidsynth-midi
> SDL_MIXER_HAS_MIDI = YES
> endif
>
> ifeq ($(BR2_PACKAGE_SDL_MIXER_MIDI_TIMIDITY),y)
> SDL_MIXER_CONF_OPTS += \
> --enable-music-midi \
> --enable-music-timidity-midi
> SDL_MIXER_HAS_MIDI = YES
> endif
>
> ifneq ($(SDL_MIXER_HAS_MIDI),YES)
> SDL_MIXER_CONF_OPTS += --disable-music-midi
> endif
It won't work then. --enable-music-midi automatically enables
--enable-music-{native,fluidsynth,timidity}-midi, so these need to be
manually disabled. Otherwise when you enable e.g. Fluidsynth, it will
also enable Timidity even though the SDL_MIXER_MIDI_TIMIDITY option is
OFF.
Cheers,
-Paul
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
More information about the buildroot
mailing list