[Buildroot] [PATCH v2, 2/4] package/celt051: needs dynamic library

[Fabrice Fontaine]

Hi Arnout,

Le lun. 27 janv. 2020 à 17:22, Arnout Vandecappelle <arnout at mind.be> a écrit :
>
>
>
> On 24/01/2020 19:14, Yann E. MORIN wrote:
> > Arnout, All,
> >
> > On 2020-01-23 23:23 +0100, Arnout Vandecappelle spake thusly:
> >> On 23/11/2019 17:05, Fabrice Fontaine wrote:
> >>> Dear Peter,
> >>>
> >>> Le sam. 23 nov. 2019 à 14:38, Peter Korsgaard <peter at korsgaard.com> a écrit :
> >>>>
> >>>>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice at gmail.com> writes:
> >>>>
> >>>>  > celt051 can't be built statically with opus as opus embeds its own celt
> >>>>  > version. So add a dynamic library dependency to celt051 (and not to
> >>>>  > opus, as celt051 is only used optionally by spice whereas opus is
> >>>>  > selected by 9 packages)
> >> [snip]
> >>>> Care to send a patch doing something like that? Thanks.
> >>> An other option would be to remove celt051 package indeed the root
> >>> cause of this static build failure is that celt has been merged into
> >>> the IETF Opus codec and is now obsolete (see http://celt-codec.org/).
> >>
> >>  Indeed, that makes more sense. Care to remove it? Legacy handling should select
> >> BR2_PACKAGE_OPUS then (with appropriate explanation).
> >>
> >>  Yann is developer for celt051, so please give a peep if it can't be removed.
> >
> > Well, celt-0.51 was introduced because at the time. spice on;y supported
> > that, and not the later versions, which is still documented in the
> > package itself.
> >
> > But sicne then (7 years ago now), spice was updated, so maybe it can
> > support newer versions, and maybe it works with Opus instead.
>
>  Opus support in spice has already been added with the bump to 0.14.1 in
> f33f7a4f6407f.
>
>  So if someone could remove celt051 please :-)
It's done since 29 hours and commit b32efbdb0354557db48852478b99080705ba315b ;-)
>
>  Regards,
>  Arnout
>
Regards,

Fabrice