[Buildroot] [PATCH 1/1] support/scripts/genimage.sh: allow setting rootpath from parameters.

[Thomas Petazzoni]

Hello Raphaël,

On Tue,  3 Sep 2019 14:09:51 +0200
raphael.melotte at essensium.com wrote:

> From: Raphaël Mélotte <raphael.melotte at essensium.com>
> 
> Previously the rootpath was always set to $TARGET_DIR.
> This patch allows using other directories as rootpath.
> 
> When you use genimage's mountpoints to generate an image with
> multiple (non-empty) partitions, it does two things:
> - copy $TARGET_DIR to $GENIMAGE_TMP/root
> - move any mountpoint from GENIMAGE_TMP/root to $GENIMAGE_TMP/<mountpoint>

The feedback on your patch was mostly negative. In addition, in the
mean time, commit 31d1fb27b0e62a6542112a7476ff188f2f7b8d38 was made,
which ensures --rootpath points to an empty directory, solving one of
the issues pointed out by your patch.

For other use-cases, a custom call to genimage is preferred, the
support/scripts/genimage.sh is not meant to be a full-featured
replacement to calling genimage directly.

So I've marked your patch as Rejected in our patch tracking system.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com