[Buildroot] [PATCH 03/11] support/scripts/pkg-stats: store patch info in a hash

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Jan 3 16:26:28 UTC 2020


On Fri, 3 Jan 2020 17:23:20 +0100
Heiko Thiery <heiko.thiery at gmail.com> wrote:

> > Note: I haven't looked at the other patches in your series yet. Maybe
> > you add more entries to the dict that make it more relevant.  
> 
> No there are no other entries in this dict.
> But thinking over that I consider removing the count filed because we
> can calculate the count from the length of the list of patches?! What
> do you think?

Yes, also thought about this when reviewing. I also saw we calculate
this count in a few places, so was not sure if it was that great to
re-do the count several times. But it's not too many times so indeed,
perhaps it's easier to keep the patch list around.

But in fact, why do you need the list of patches ? Your web site only
shows the patch count anyway.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list