[Buildroot] [PATCH 1/5] utils/scancpan: warn when a module is a perl core module
Thomas De Schampheleire
patrickdepinguin at gmail.com
Fri Jan 3 15:56:57 UTC 2020
Hello Yann, François,
El dom., 22 dic. 2019 a las 17:33, Yann E. MORIN
(<yann.morin.1998 at free.fr>) escribió:
>
> François, All,
>
> On 2019-12-22 17:21 +0100, Francois Perrad spake thusly:
> > Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
>
> This change does need to be explained in the commit log:
>
> - Why is it bad that we have a pacakge that is a core module?
> - Does it cause any issue? If so, which one?
>
> Also, when you do removes package, the least is to add in Cc the people
> that initially added the package, so they have a chance to chime in and
> explain why they wanted to add it in the first place, and so they can
> confirm that the core module does indeed work for them.
>
> I'll mark the whole series as Changes Requested in Patchowrk. Please
> respin with explanations, and Cc original packagers.
>
When submitting the package perl-math-bigint I was not aware that it
was a core package.
After François mentioned it, we checked internally if indeed things
work fine without the Buildroot package, and it is the case.
So, there is no need for package/perl-math-bigint.
There is no actual harm by also having a Buildroot package, except for:
- unneeded stuff in Buildroot
- potential to eclipse a newer version of the package when
package/perl evolves but package/perl-math-bigint does not.
So from my point of view I would indeed remove the package again.
I was actually going to send a revert but then I saw this series.
Best regards,
Thomas
More information about the buildroot
mailing list