[Buildroot] [PATCH] package/openrc: needs kmod

Carlos Santos unixmania at gmail.com
Fri Feb 28 21:47:43 UTC 2020


On Fri, Feb 28, 2020 at 5:26 PM Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>
> openrc provides scritps that have been written for the big-gun kmod, and
> so use options unknown to the biusybox' provided applets:
>
>   - Busybox modprobe does not have a "--first-time" option,
>   - the "--verbose" option is just "-v",
>   - the "--use-blacklist" option is just "-b". Also blacklist support is
>     not selected in our default busybox configuration.
>
> One of two options, is to "fix" or "adapt" openrc's scripts to busybox,
> which means for the openrc package to go peek into files from the
> busybox package, which is not nice, and can't work because that is not
> available by the time we scan our Makefiles.
>
> The other option, which this patch implements, is to just add a
> dependency onto kmod and its tools.
>
> Reported-by: Carlos Santos <unixmania at gmail.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
> Cc: Peter Korsgaard <peter at korsgaard.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> ---
>  package/openrc/Config.in | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/package/openrc/Config.in b/package/openrc/Config.in
> index 796858f404..4691be63a2 100644
> --- a/package/openrc/Config.in
> +++ b/package/openrc/Config.in
> @@ -3,6 +3,9 @@ config BR2_PACKAGE_OPENRC
>         depends on BR2_USE_MMU # fork()
>         depends on !BR2_STATIC_LIBS
>         depends on BR2_INIT_OPENRC
> +       select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod tools
> +       select BR2_PACKAGE_KMOD # runtime
> +       select BR2_PACKAGE_KMOD_TOOLS # runtime
>         select BR2_PACKAGE_NCURSES
>         help
>           Init that works on top of pid 1 (for example
> --
> 2.20.1
>

What about doing the opposite?

1. Always patch openrc to support busybox.' modprobe.
2. In busybox, select modprobe+blacklist if openrc is selected but
kmod tools are not selected.

This would be cleaner and seems to be reasonable, since busybox
already sets several configurations based on the selection of other
packages.

-- 
Carlos Santos <unixmania at gmail.com>


More information about the buildroot mailing list