[Buildroot] [PATCH] package/qt5tools: hide qdoc with llvm dependencies

Romain Naour romain.naour at smile.fr
Fri Feb 28 15:30:33 UTC 2020


Yann, All,

Le 28/02/2020 à 16:28, yann.morin at orange.com a écrit :
> Romain, All,
> 
> On 2020-02-28 16:16 +0100, Romain Naour spake thusly:
>> Le 28/02/2020 à 15:00, yann.morin at orange.com a écrit :
>>> From: "Yann E. MORIN" <yann.morin at orange.com>
>>>
>>> Building qdoc requires a llvm and clang for the host.
>>>
>>> However, there is a limitation in the llvm and clang packages in
>>> Buildroot, which makes it impossible to havea  host variant without
>>
>> s/havea/have a/
>>
>>> a target variant.
>>>
>>> So, propagate the dependencies of the target llvm and clang, to ensure
>>> we can only have a host-llvm and -clang packages that are correctly
>> host-clang
> 
> That was done on purpose, and is called an ellipsis. ;-]

Well, I was not sure :p
Typo or not typo ?

Best regards,
Romain


> 
> Regards,
> Yann E. MORIN.
> 
>>> built.
>>>
>>> Note that we do propagate all of the dependencies (instead of just the
>>> architecture part), to be consistent.
>>>
>>> Reported-by: Romain Naour <romain.naour at smile.fr>
>>> Signed-off-by: Yann E. MORIN <yann.morin at orange.com>
>>> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
>>> Cc: Peter Seiderer <ps.report at gmx.net>
>>> Cc: Julien Corjon <corjon.j at ecagroup.com>
>>> ---
>>>  package/qt5/qt5tools/Config.in | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/package/qt5/qt5tools/Config.in b/package/qt5/qt5tools/Config.in
>>> index 14178abc29..60106c1ee3 100644
>>> --- a/package/qt5/qt5tools/Config.in
>>> +++ b/package/qt5/qt5tools/Config.in
>>> @@ -19,6 +19,16 @@ config BR2_PACKAGE_QT5TOOLS_LINGUIST_TOOLS
>>>  
>>>  config BR2_PACKAGE_QT5TOOLS_QDOC_TOOL
>>>  	bool "qdoc host tool"
>>> +	# Needs llvm-config and libclang for the host, which is not
>>> +	# currently supported in Buildroot, unless the target is
>>> +	# already supported by llvm.
>>> +	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS # llvm, clang
>>> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # llvm, clang
>>> +	depends on BR2_TOOLCHAIN_HAS_THREADS # llvm, clang
>>> +	depends on BR2_INSTALL_LIBSTDCPP # llvm, clang
>>> +	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # llvm, clang
>>> +	depends on !BR2_STATIC_LIBS # llvm, clang
>>> +	depends on BR2_USE_WCHAR # llvm, clang
>>>  	help
>>>  	  This option enables the qdoc host tool.
>>>  
>>>
>> Reviewed-by: Romain Naour <romain.naour at smile.fr>
>>
>> Best regards,
>> Romain
>>
> 



More information about the buildroot mailing list