[Buildroot] [PATCH] package/lvm2: lvmetad systemd integration

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Feb 28 10:17:42 UTC 2020


Hello Pascal!

On Fri, 28 Feb 2020 09:18:59 +0100
Pascal de Bruijn <p.debruijn at unilogic.nl> wrote:

> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 43370b03bf..6b866ce92b 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -54,6 +54,14 @@ else
>  LVM2_CONF_OPTS += --disable-applib
>  endif
>  
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +LVM2_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install install_systemd_units install_systemd_generators
> +endif

This should be in a separate change, as it's unrelated.

Also, I'd prefer:

LVM2_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install

ifeq ($(BR2_PACKAGE_SYSTEMD),y)
LVM2_INSTALL_TARGET_OPTS += install_systemd_units install_systemd_generators
endif

> +ifeq ($(BR2_PACKAGE_LVM2_LVMETAD),y)
> +LVM2_CONF_OPTS += --enable-lvmetad

else

LVM2_CONF_OPTS += --disable-lvmetad


> +endif

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list