[Buildroot] [PATCH 1/2] package/pkg-generic.mk: simplify step_pkg_size

Peter Korsgaard peter at korsgaard.com
Thu Feb 27 22:32:22 UTC 2020

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

 > On Thu, 27 Feb 2020 22:51:08 +0100
 > Peter Korsgaard <peter at korsgaard.com> wrote:

 >> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:  
 >> > Use the same trick in step_pkg_size as the one used in check_bin_arch:
 >> > factorize the two $(filter ...) calls into one, checking in one step
 >> > the step and whether it's the beginning or end of the step.  
 >> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>  
 >> Committed, thanks.

 > Is this something you applied to master?


 > Even though PATCH 2/2 fixes some build issues, it is also a pretty
 > radical change and I'm not sure it's a good idea to apply to master so
 > late in the dev cycle.

I know, but what is the alternative? Tell people to not use the toplevel
parallel build feature? That also isn't really great.

Bye, Peter Korsgaard

More information about the buildroot mailing list