[Buildroot] [PATCH 2/2] package/git: fix build failure due to gcc bug 93847

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Feb 27 08:17:25 UTC 2020


Hello Peter,

On Wed, 26 Feb 2020 23:22:08 +0100
Peter Korsgaard <peter at korsgaard.com> wrote:

>  > -ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
>  > +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180)$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),y)  
> 
> This fails for a (hypothetical) toolchain affected by both issues,
> perhaps something like this would be better?
> 
> ifneq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180)$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),)

True in the general case. But BR2_TOOLCHAIN_HAS_GCC_BUG_85180 only
applies to Microblaze, and BR2_TOOLCHAIN_HAS_GCC_BUG_93847 to NIOS2. So
practically speaking, they are mutually exclusive options, so the case
where both are enabled at the same time is impossible.

But I agree that in the general case what you showed would be
preferable.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list