[Buildroot] [PATCH] package/fail2ban: The (host-python3) 2to3 utility needs to be present

Peter Korsgaard peter at korsgaard.com
Wed Feb 26 15:29:21 UTC 2020


>>>>> "Baruch" == Baruch Siach <baruch at tkos.co.il> writes:

 > Hi Pascal,
 > On Wed, Feb 26 2020, Pascal de Bruijn wrote:
 >> During _POST_PATCH_HOOKS _DEPENDANCIES aren't guaranteed to be built,
 >> however during _PRE_CONFIGURE_HOOKS they should be built.
 >> 
 >> Should fix:
 >> http://autobuild.buildroot.net/results/dd8e225e2a49cfa6735bed11459007003a37c137/
 >> http://autobuild.buildroot.net/results/e688c3652bd474ac682984e2e5947701942f0f57/

 > Thanks for following up on this.

 >> Cc: Baruch Siach <baruch at tkos.co.il>
 >> Signed-off-by: Pascal de Bruijn <p.debruijn at unilogic.nl>
 >> ---
 >> package/fail2ban/fail2ban.mk | 2 +-
 >> 1 file changed, 1 insertion(+), 1 deletion(-)
 >> 
 >> diff --git a/package/fail2ban/fail2ban.mk b/package/fail2ban/fail2ban.mk
 >> index 6f023b48a1..6cb77c2514 100644
 >> --- a/package/fail2ban/fail2ban.mk
 >> +++ b/package/fail2ban/fail2ban.mk
 >> @@ -15,7 +15,7 @@ define FAIL2BAN_PYTHON_2TO3
 >> $(HOST_DIR)/bin/2to3 --write --nobackups --no-diffs $(@D)/bin/* $(@D)/fail2ban
 >> endef
 >> FAIL2BAN_DEPENDENCIES += host-python3
 >> -FAIL2BAN_POST_PATCH_HOOKS += FAIL2BAN_PYTHON_2TO3
 >> +FAIL2BAN_PRE_CONFIGURE_HOOKS += FAIL2BAN_PYTHON_2TO3

 > As Thomas suggested please add a comment here. Something like:

 > # We can't use _POST_PATCH_HOOKS because dependencies are not guaranteed
 > # to build and install before _POST_PATCH_HOOKS run.

Committed after adding that comment, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list