[Buildroot] [PATCH v2 2/2] package/frr: new package

[Vadim Kochan]

On Tue, Feb 25, 2020 at 5:37 PM Vadim Kochan <vadim4j at gmail.com> wrote:
>
> On Tue, Feb 25, 2020 at 2:39 PM Heiko Thiery <heiko.thiery at gmail.com> wrote:
> >
> > Hi Vadim and all,
> >
> > > >
> > > > I see that thei install step installs examples in a directory where (I
> > > > think) it never should install stuff! It is the targetno directory.
> > > >
> > > >  /usr/bin/install -c -m 644 zebra/zebra.conf.sample
> > > > bgpd/bgpd.conf.sample bgpd/bgpd.conf.sample2 bgpd/bgpd.conf.vnc.sample
> > > > ripd/ripd.conf.sample ripngd/ripngd.conf.sample
> > > > ospfd/ospfd.conf.sample ospf6d/ospf6d.conf.sample
> > > > isisd/isisd.conf.sample isisd/fabricd.conf.sample
> > > > ldpd/ldpd.conf.sample babeld/babeld.conf.sample
> > > > eigrpd/eigrpd.conf.sample pimd/pimd.conf.sample pbrd/pbrd.conf.sample
> > > > staticd/staticd.conf.sample bfdd/bfdd.conf.sample
> > > > vtysh/vtysh.conf.sample
> > > > '/home/hthiery/sources/mainline/buildroot/output/targetno'
> > > >
> > > >
> > > > I cannot see how it is possible to properly disable the install of
> > > > examples. I see that you already have set the option
> > > > --disable-exampledir. But this seems not to be enought, or it is
> > > > broken.
> > >
> > > Wow! Nice catch, I did not realize this, so there are like at least 2 options ?
> > > 1) remove it in hook
> > > 2) patch the frr build scripts (which looks like more safer?)
> >
> > I think reporting that upstream and patching would be the best solution.
> >
> Hm, problem is that this --enable-exampledir is used as bool option to specify
> alternative path for installing config samples, and because I set it
> to "--disable-exampledir"
> then this value is set to "no" and eventually is appended to DESTDIR
> which is $(TARGET_DIR),
> which is evaluated to .../targetno.
>
> But is this a problem if config samples will be installed to
> $(TARGET_DIR)/etc/frr (which is default
> if to remove --disable-exampledir) ?

Actually I can remove them in POST_INSTALL hook )