[Buildroot] [PATCH] package/libsvgtiny: fix parallel build

Giulio Benetti giulio.benetti at benettiengineering.com
Sun Feb 23 13:35:52 UTC 2020



On 2/23/20 1:01 AM, Romain Naour wrote:
> Hi Giulio,
> 
> Le 22/02/2020 à 22:44, Giulio Benetti a écrit :
>> Fix previous commit[1] which purpose was to fix parallel build. It
>> didn't work since it assigned $(MAKE1) to LIBSVGTINY_MAKE, but this is a
>> generic-package and building is done using $(MAKE), then LIBSVGTINY_MAKE
>> was ignored. Let's substitute instead $(MAKE) with $(MAKE1) in
>> LIBSVGTINY_BUILD_CMDS.
> 
> Nice catch!

Thanks for reviewing :-)

>>
>> [1]:
>> https://git.buildroot.net/buildroot/commit/?id=26d67a2599d6c88facd5178de853fa355244e7c2
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/67d/67d341c0cc272323d6e231a20796a6848c21d760/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
>> ---
>>   package/libsvgtiny/libsvgtiny.mk | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/package/libsvgtiny/libsvgtiny.mk b/package/libsvgtiny/libsvgtiny.mk
>> index fe7dc0a6d2..a2165d5b7e 100644
>> --- a/package/libsvgtiny/libsvgtiny.mk
>> +++ b/package/libsvgtiny/libsvgtiny.mk
>> @@ -12,8 +12,6 @@ LIBSVGTINY_DEPENDENCIES = \
>>   	libxml2 host-gperf host-pkgconf host-netsurf-buildsystem
>>   LIBSVGTINY_LICENSE = MIT
>>   LIBSVGTINY_LICENSE_FILES = README
>> -# Package does not build in parallel due to improper make rules
>> -LIBSVGTINY_MAKE = $(MAKE1)
>>   
>>   # The libsvgtiny build system cannot build both the shared and static
>>   # libraries. So when the Buildroot configuration requests to build
>> @@ -29,7 +27,8 @@ define LIBSVGTINY_CONFIGURE_CMDS
>>   endef
>>   
> (*) here.
>>   define LIBSVGTINY_BUILD_CMDS
>> -	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) PREFIX=/usr \
> Usually comments are outside of the define (*)
>> +# Use $(MAKE1) since parallel build fails
>> +	$(TARGET_CONFIGURE_OPTS) $(MAKE1) -C $(@D) PREFIX=/usr \
>>   		COMPONENT_TYPE=$(LIBSVGTINY_COMPONENT_TYPE)
> 
> I would add MAKE1 for other steps (LIBSVGTINY_INSTALL_STAGING_CMDS and
> LIBSVGTINY_INSTALL_TARGET_CMDS).

Yann already fixed everything and applied.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> Best regards,
> Romain
> 
> 
>>   endef
>>   
>>
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 



More information about the buildroot mailing list