[Buildroot] [PATCH] infra: don't be verbose when calling the instrumentation steps

Thomas De Schampheleire patrickdepinguin at gmail.com
Sat Feb 22 10:59:00 UTC 2020


Hi Yann,

On Sat, Feb 22, 2020, 11:38 Yann E. MORIN <yann.morin.1998 at free.fr> wrote:

> Commit 509db3b88a added calls to (parts of) the instrumentation steps.
> However, those calls are echoed, unlike the other places where we call
> them (in the package infra).
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
> ---
>  Makefile | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9662987bb4..b61a20a354 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -807,12 +807,12 @@ endif # merged /usr
>  # AFTER ALL FILE-CHANGING ACTIONS:
>  # Update timestamps in internal file list to fix attribution of files
>  # to packages on subsequent builds
> -       $(call step_pkg_size_file_list,$(TARGET_DIR))
> -       $(call step_pkg_size_finalize)
> -       $(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> -       $(call step_pkg_size_finalize,-staging)
> -       $(call step_pkg_size_file_list,$(HOST_DIR),-host)
> -       $(call step_pkg_size_finalize,-host)
> +       @$(call step_pkg_size_file_list,$(TARGET_DIR))
> +       @$(call step_pkg_size_finalize)
> +       @$(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> +       @$(call step_pkg_size_finalize,-staging)
> +       @$(call step_pkg_size_file_list,$(HOST_DIR),-host)
> +       @$(call step_pkg_size_finalize,-host)


Perhaps this should rather be $(Q) than @?
I quite like the fact that you can see what's going on, mostly relevant
when investigating an issue...

Thanks,
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200222/ef78015e/attachment.html>


More information about the buildroot mailing list