[Buildroot] [PATCH v5 1/1] package/nodejs: Use zlib headers from HOST_ZLIB_SRCDIR for host-nodejs

James Hilliard james.hilliard1 at gmail.com
Tue Feb 18 03:15:21 UTC 2020


The nodejs configure.py file orders zlib headers before the bundled ICU
headers. The zlib headers happen to be located in the system include
directory, next to some system ICU headers (not bundled). If these are
built before nodejs is, nodejs will get confused and try to use the
system ICU headers instead of the bundled ones.

Fix this by using headers from HOST_ZLIB_SRCDIR so that the ICU headers
in the system include directory are not used.

Signed-off-by: Thomas Preston <thomas.preston at codethink.co.uk>
Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
---
Changes v4 -> v5:
  - use headers from HOST_ZLIB_SRCDIR
  - use shared zlib instead of static zlib
---
 package/nodejs/nodejs.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 0de3495df9..30f5b35809 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -64,6 +64,8 @@ define HOST_NODEJS_CONFIGURE_CMDS
 		--shared-openssl-includes=$(HOST_DIR)/include/openssl \
 		--shared-openssl-libpath=$(HOST_DIR)/lib \
 		--shared-zlib \
+		--shared-zlib-includes=$(HOST_ZLIB_SRCDIR) \
+		--shared-zlib-libpath=$(HOST_DIR)/lib \
 		--no-cross-compiling \
 		--with-intl=small-icu \
 	)
-- 
2.20.1



More information about the buildroot mailing list