[Buildroot] [PATCH v2,3/3] package/parted: disable on uclibc

Peter Korsgaard peter at korsgaard.com
Fri Feb 14 08:13:21 UTC 2020


>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice at gmail.com> writes:

 > Like postgreSQL (and imagemagick), parted does not build against uClibc
 > with locales enabled, due to an uClibc bug, see
 > http://lists.uclibc.org/pipermail/uclibc/2014-April/048326.html:

 > In file included from atari.c:42:
 > atari.c: In function 'atr_part_correct':
 > atari.c:221:9: error: dereferencing pointer to incomplete type 'struct __uclibc_locale_struct'
 >   return isalnum_l(part->id[0], atr_c_locale)
 >          ^~~~~~~~~

 > So disable parted on uclibc

 > Fixes:
 >  - http://autobuild.buildroot.org/results/992518d340a9f32a0721d6e66936850c4c3ef2e4

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
 > ---
 > Changes v1 -> v2 (after review of Peter Korsgaard):
 >  - Update parted's reverse dependencies

Committed after fixing the white space issues, thanks.

check-package warns about this:

Applying: package/parted: disable on uclibc
package/python-pyparted/Config.in:15: line contains trailing whitespace
package/python-pyparted/Config.in:15: empty line at end of file
92 lines processed
2 warnings generated

Consider adding a post-commit hook with it, E.G. something like:

cat .git/hooks/post-commit
#!/bin/sh
#
# An example hook script that is called after a successful
# commit is made.
#
# To enable this hook, rename this file to "post-commit".

# check-package on added/changed files
git show --no-renames HEAD | \
        lsdiff -s | \
        awk '{ if ($1 != "-") print substr($2, 3) }' | \
        xargs -r ./utils/check-package

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list