[Buildroot] [PATCH 1/4] boot/arm-trusted-firmware: Disable bin copy for rk3399

Jagan Teki jagan at amarulasolutions.com
Thu Feb 13 08:06:53 UTC 2020


On Thu, Feb 13, 2020 at 12:53 PM Sergey Matyukevich <geomatsi at gmail.com> wrote:
>
> Hi,
>
> > Unlike other SoC platforms, rockchip platforms doesn't require a binary
> > generation on TF-A project.
> >
> > This is due to rockchip platforms have non-continuous memory areas in
> > the linker script with a huge gap between them, so generating the binary
> > would require addition padding which indeed increases the size of the binary.
> >
> > Interestingly this binary generation is disabled in v2.2 of TF-A on below
> > commit:
> >  commit <33218d2a8143> "rockchip: Disable binary generation for all SoCs."
> >
> > So, select default binary boot images as *.bin only if it's not rk3399.
> >
> > This fixes the atf build on rk3399 with v2.2.
> >
> > Note: the same can be applied to rest of rockchip platforms if
> > they use v2.2 TF-A.
> >
> > Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> > Tested-by: Suniel Mahesh <sunil at amarulasolutions.com>
> > ---
> >  boot/arm-trusted-firmware/Config.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> ...
>
> >  config BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES
> >       string "Binary boot images"
> > -     default "*.bin"
> > +     default "*.bin" if BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM!=rk3399
> >       help
> >         Names of generated image files that are installed in the
> >         output images/ directory.
>
> IIUC, it should be customized in your board defconfig.

Not sure of it. Technically this is how rockchip SoC behaves wrt ATF
build. If we mark BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES="" to all
supporting boards of  rockchip start with rk3399, rk3288 etc.. it
ended up huge and meaningless change, IMHO.

Jagan.


More information about the buildroot mailing list