[Buildroot] [PATCH v4 6/9] board/qemu: add post-image script for gitlab qemu testing

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Feb 10 13:09:50 UTC 2020


On Sun,  9 Feb 2020 19:03:24 +0100
Romain Naour <romain.naour at smile.fr> wrote:

> This commit add the same post-image script for each qemu board
> in order to generate start-qemu.sh in BINARIES_DIR.
> The start-qemu.sh script can be used by Buildroot user to start
> Qemu or by a gitlab CI.
> 
> To find the correct qemu command line in the readme.txt, we use
> the second post script argument which must contain "$(BR2_DEFCONFIG)"
> 
>   BR2_ROOTFS_POST_SCRIPT_ARGS="$(BR2_DEFCONFIG)"
> 
> Doing a basename allow to retrieve the name of the defconfig
> file (ex: qemu_aarch64_virt_defconfig) that should match
> on on the "tag" previously introduced in the readme.txt.
> 
> The script start-qemu.sh is able to modify the qemu command
> line if CI_JOB_NAME defined in the environment. This allow
> to disable the graphical output and redirect serial I/Os to
> console.
> 
> Only sh4/sh4eb needs a special handling by adding
> "-serial stdio -display none" instead of "-display none".
> 
> Signed-off-by: Romain Naour <romain.naour at smile.fr>

Why is this script copied a zillion times? This looks like a
maintenance nightmare. Why not put it in board/qemu/, and have a single
script used by all configurations ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list