[Buildroot] [PATCH v2] package/ninja: fix build for cmake 3.10
peter at korsgaard.com
Fri Feb 7 14:59:51 UTC 2020
>>>>> "yegorslists" == yegorslists <yegorslists at googlemail.com> writes:
> From: Yegor Yefremov <yegorslists at googlemail.com>
> If the host cmake is 3.10, the configuration step produces
> the following error:
> CMake Error at CMakeLists.txt:87 (target_link_libraries):
> Target "libninja" of type OBJECT_LIBRARY may not be linked into another
> target. One may link only to STATIC or SHARED libraries, or to executables
> with the ENABLE_EXPORTS property set.
> This patch fixes CMakeLists.txt to use the object library as it was intended
> in cmake 3.10.
> Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
> Tested-by: Damian Tometzki <dti at familie-tometzki.de>
> Changes v1 -> v2:
> - add Tested-by tag from Damian
> - mention bug report
Please use the -N option when generating patches from git (here and the
libftdi1 patch) - check-package complains:
Applying: package/ninja: fix build for cmake 3.10
package/ninja/0003-CMake-fix-object-library-usage.patch:4: generate your patches with 'git format-patch -N'
Committed with that fixed, thanks.
Bye, Peter Korsgaard
More information about the buildroot